Conversation
luhenry
added a commit
that referenced
this pull request
Sep 7, 2026
pyproject.toml's classic license = {file = "LICENSE.txt"} suppresses
setuptools' default LICEN[CS]E* glob, so LICENSE.nng/LICENSE.mbedtls
staged by the workflow were silently dropped from the wheel's licence
metadata (the cp312/cp314/cp314t CI jobs caught this: the wheel shipped
none of the three license files at all). Patch pyproject.toml to declare
license-files explicitly, and fix the CIBW_TEST_COMMAND assertion, which
had assumed a dist-info/licenses/ subfolder this setuptools version
does not use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pynng0.9.0Builds pynng's CFFI binding to nng, which statically links nng and mbedtls (both cloned and compiled from source at build time by
setup.py). Upstream publishes no riscv64 wheel.Mirrors upstream's
cibuildwheel.yml.Differs from upstream
Testing
License: Wheel bundles nng (MIT) and mbedtls (Apache-2.0 OR GPL-2.0-or-later); upstream's wheel carries only its own LICENSE, so the build stages LICENSE.nng and LICENSE.mbedtls too.